Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2796 Rename package Store -> store #3068

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixes #2796 Rename package Store -> store #3068

wants to merge 4 commits into from

Conversation

chrisdennis
Copy link
Member

No description provided.

@AbfrmBlr
Copy link
Contributor

This PR is daggy, want to merge in some other branch as well?

@chrisdennis chrisdennis marked this pull request as draft October 13, 2022 13:32
@chrisdennis
Copy link
Member Author

Pretty sure the merge in this is busted... I need to come back and look at it again later today.

@chrisdennis chrisdennis marked this pull request as ready for review December 14, 2022 23:07
@cljohnso
Copy link
Contributor

The failed test, org.ehcache.clustered.replication.BasicClusteredCacheOpsReplicationMultiThreadedTest > testCRUD[consistency=EVENTUAL], appears to be a bit racy. It looks like it could use some additional coordination to ensure things actually get started before the ACTIVE is clobbered. May be some additional coordination needed between the "put" threads and the "get" thread. And are there enough executor threads to permit this test to run reliably -- 21 tasks vs 10 threads.

Definitely not related to your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cljohnso cljohnso cljohnso approved these changes

@AbfrmBlr AbfrmBlr AbfrmBlr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisdennis @AbfrmBlr @cljohnso